This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/6] microblaze: Fixes for RTL checking
On Tue, Feb 21, 2017 at 12:35:17PM -0800, Michael Eager wrote:
> On 02/21/2017 12:15 PM, Jakub Jelinek wrote:
> >On Tue, Feb 21, 2017 at 02:48:15PM +0000, Segher Boessenkool wrote:
> >>- /* Shift by zero -- copy regs if necessary. */
> >>+ /* Shift by zero -- copy regs. */
> >> if ((GET_CODE (operands[2]) == CONST_INT) && (INTVAL (operands[2]) ==
> >> 0))
> >
> >You could have changed this line to
> > if (operands[2] == const0_rtx)
> >as well.
>
> And this would not change the generated code.
Of course, but you still need the other changes.
I did not make this random cleanup because a) it is a random cleanup; and
b) there are at least three occurrences of this in both microblaze.c and
microblaze.md .
Michael, will you make a fix yourself? --enable-checking=yes,rtl will
reproduce the problem.
Segher