This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix fixincludes for canadian cross builds
On 02/18/17 01:01, Bernd Edlinger wrote:
> On 02/18/17 00:37, Bruce Korb wrote:
>> On 02/06/17 10:44, Bernd Edlinger wrote:
>>> I tested this change with different arm-linux-gnueabihf cross
>>> compilers, and verified that mkheaders still works on the host system.
>>>
>>> Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
>>> Is it OK for trunk?
>>
>> As long as you certify that this is correct for all systems we care about:
>>
>> +BUILD_SYSTEM_HEADER_DIR = `
>> + echo $(CROSS_SYSTEM_HEADER_DIR) | \
>> + sed -e :a -e 's,[^/]*/\.\.\/,,' -e ta`
>>
>> that is pretty obtuse sed-speak to me. I suggest a comment
>> explaining what sed is supposed to be doing. What should
>> "$(CROSS_SYSTEM_HEADER_DIR)" look like?
>>
>
> I took it just from a few lines above, so I thought that comment would
> sufficiently explain the syntax:
I confess, I didn't pull a new copy of gcc, sorry.
So it looks good to me.