This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Pretty printers for versioned namespace
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 16 Feb 2017 12:11:05 +0000
- Subject: Re: Pretty printers for versioned namespace
- Authentication-results: sourceware.org; auth=none
- References: <20170104125240.GH895@redhat.com> <9b83337c-ee12-df97-9035-7636955f0bf9@gmail.com> <20170110123911.GK13348@redhat.com> <9e4934b5-9aaf-dc90-b54a-f2b58a91a12f@gmail.com> <20170119212157.GP3093@redhat.com> <b26a2ed4-ac83-ede4-ed9c-f3b328d7bc4a@gmail.com> <20170131144204.GX3093@redhat.com> <2c905325-8839-bb5d-4885-0103801a6264@gmail.com> <20170213223132.GV4602@redhat.com> <a6f4717a-1d63-beb6-6a93-c111969ce4fa@gmail.com>
On 15/02/17 22:44 +0100, François Dumont wrote:
Hi
Here is the end result. I eventually chose to detect usage of
versioned namespace while generating the .gdb file. I haven't use any
caching mecanism considering the limited number of test cases.
Tested under Linux x86_64 with and without versioned namespace.
* python/Makefile.am (use_versioned_namespace): New.
(gdb.py): Subst use_versioned_namespace.
* python/Makefile.in: Regenerate.
* python/hook.in: Adapt.
* python/libstdcxx/v6/printers.py (Printer.add_version): Add name
versioned namespace if _versioned_namespace is defined.
(Printer.add_one_template_type_printer): Likewise
(add_one_type_printer): Likewise.
(register_libstdcxx_printers): Add parameter to indicate if versioned
namespace is active.
* testsuite/lib/gdb-test.exp (get_use_versioned_namespace): New.
(gdb-test): Use latter.
* testsuite/libstdc++-prettyprinters/48362.cc: Prefer note-test to
regexp-test.
Ok to commit to trunk ?
No, I thought the point of the use_versioned_namespace parameter was
to optimise thigns later, if needed. Do we need to do it?
We certainly don't need to do it during stage 4, as it's not actually
fixing any bug.
Let's reconsider during stage 1.