This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix i386 REG_CLASS_NAMES
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 13 Feb 2017 20:56:45 +0100
- Subject: Re: [PATCH] Fix i386 REG_CLASS_NAMES
- Authentication-results: sourceware.org; auth=none
- References: <20170213194538.GN1849@tucnak>
On Mon, Feb 13, 2017 at 8:45 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> Unlike the previous patch that is mainly about diagnostics or dump
> text, this one is something that could potentially crash the compiler,
> the missing , in between means MOD4_SSE_REGS class has
> MOD4_SSE_REGSALL_REGS name and ALL_REGS class will have NULL or whatever.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2017-02-13 Jakub Jelinek <jakub@redhat.com>
>
> * config/i386/i386.h (REG_CLASS_NAMES): Add , in between
> "MOD4_SSE_REGS" and "ALL_REGS".
OK.
Thanks,
Uros.
> --- gcc/config/i386/i386.h.jj 2017-02-07 16:40:46.000000000 +0100
> +++ gcc/config/i386/i386.h 2017-02-13 11:31:46.020532661 +0100
> @@ -1427,7 +1427,7 @@ enum reg_class
> "FLOAT_INT_SSE_REGS", \
> "MASK_EVEX_REGS", \
> "MASK_REGS", \
> - "MOD4_SSE_REGS" \
> + "MOD4_SSE_REGS", \
> "ALL_REGS" }
>
> /* Define which registers fit in which classes. This is an initializer
>
> Jakub