This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add Ada support for aarch64-*-freebsd*


On 2/7/2017 07:53, Arnaud Charlet wrote:
I was pointing out that on gcc-6, aarch64-linux is using x86-64
system file too.  Since I used gcc-6 for the original testing on
freebsd, that's where it came from.  It's been changed on trunk, but
nobody backported those changes to gcc-6.  It was obviously "good
enough" and a "placeholder" as indicated in the nearby comment.

Well, that's a bad practice that we want to fix rather than copy :-)

If you want, I can create a duplicate file with a different name.
Or I can add a "placeholder" comment like we see on aarch64-linux.
Adding a new system file would not change the end result but if you
like it more, I'll submit a new patch that creates this new system
file.

Given that the more recent trend is to merge more these system files
as opposed to systematically breaking them, I'd recommend renaming the
file to system-freedbsd and change the definition of Default_Bit_Order
which will be needed sooner or later in any case (if not already).


Okay, I'll modify the patch accordingly. It increases the complexity but if that's the correct approach then so be it.

John


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]