This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite, i386] Require ifunc support in gcc.target/i386/pr78419.c
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, Martin Liška <mliska at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 7 Feb 2017 10:40:05 +0100
- Subject: Re: [testsuite, i386] Require ifunc support in gcc.target/i386/pr78419.c
- Authentication-results: sourceware.org; auth=none
- References: <ydd1sva9wi6.fsf@CeBiTec.Uni-Bielefeld.DE>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Feb 07, 2017 at 10:32:33AM +0100, Rainer Orth wrote:
> Within the last 3 days, gcc.target/i386/pr78419.c started to FAIL on
> Solaris/x86:
>
> FAIL: gcc.target/i386/pr78419.c (test for excess errors)
>
> Excess errors:
> /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.target/i386/pr78419.c:10:10: error: the call requires ifunc, which is not supported by this target
>
> Initially I thought: no wonder, Solaris ld.so.1 lacks ifunc support and
> installed the following patch as obvious, requiring ifunc support as in
> gcc.target/i386/mvc?.c.
>
> Looking closer, however, I noticed that the testcase had already been
> installed in November and had PASSed even on Solaris ever since. I
> suppose the fix is still correct, but this remains strange.
Perhaps r245155 ?
Your patch is ok.
> 2017-02-07 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> * gcc.target/i386/pr78419.c: Require ifunc support.
>
> # HG changeset patch
> # Parent 5a45f3c6319c555ed326c7f2d22cc54989105f09
> Require ifunc support in gcc.target/i386/pr78419.c
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr78419.c b/gcc/testsuite/gcc.target/i386/pr78419.c
> --- a/gcc/testsuite/gcc.target/i386/pr78419.c
> +++ b/gcc/testsuite/gcc.target/i386/pr78419.c
> @@ -1,5 +1,6 @@
> /* PR middle-end/78419 */
> /* { dg-do compile } */
> +/* { dg-require-ifunc "" } */
>
> static double bar (double *__restrict, double *__restrict, int)
> __attribute__ ((target_clones("avx,foo,avx2,avx512f,default")));
Jakub