This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix profile updating in ifcombine
On 07/02/17 08:37, Christophe Lyon wrote:
> Hi,
>
>
> On 6 February 2017 at 17:56, Richard Earnshaw (lists)
> <Richard.Earnshaw@arm.com> wrote:
>> On 06/02/17 15:54, Jiong Wang wrote:
>>> On 06/02/17 15:26, Jan Hubicka wrote:
>>>> I think it is not a regression, just the testcase if fragile and
>>>> depends on outcome
>>>> of ifcombine. It seems it was updated several time in the past. I am
>>>> not quite
>>>> sure what the test is testing.
>>>
>>> They are tring to make sure optimal stack adjustment decisions are made.
>>>
>>> Fix the testcases by disabling relevant transformation passes looks one
>>> way to
>>> me. The other way, might be more reliable, is we dump the decisions
>>> made during
>>> aarch64 frame layout if dump_file be true, and prefix the dump entry by
>>> function
>>> name to make it easier caught by dejagnu. We then scan rtl dump instead of
>>> instructions.
>>>
>>>
>>
>> We only care that the epilogue instructions appear at least once. So
>> for the epilogue we should probably just adjust the tests to use
>> scan-assembler, rather than scan-assembler-times.
>>
>
> Here is a patch do to that, it also updates tests 8, 10 and 12 which
> have similar
> matching patterns.
>
> OK?
>
>> R.
OK.
R.