This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/6] RISC-V Port: gcc
- From: Palmer Dabbelt <palmer at dabbelt dot com>
- To: sandra at codesourcery dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Cc: Andrew Waterman <andrew at sifive dot com>
- Date: Mon, 06 Feb 2017 10:21:55 -0800 (PST)
- Subject: Re: [PATCH 2/6] RISC-V Port: gcc
- Authentication-results: sourceware.org; auth=none
On Sun, 05 Feb 2017 21:36:29 PST (-0800), sandra@codesourcery.com wrote:
> I didn't see a v3 with the documentation patches go by yet, and I had
> some nit-picky comments on v2 (in addition to the ones Joseph already
> asked for):
No problem.
> > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
>> index 4b13aeb..581c4ef 100644
>> --- a/gcc/doc/invoke.texi
>> +++ b/gcc/doc/invoke.texi
>> @@ -1046,6 +1046,20 @@ See RS/6000 and PowerPC Options.
>> -mstack-protector-guard-offset=@var{offset} @gol
>> -mlra -mno-lra}
>>
>> +@emph{RISC-V Options}
>> +@gccoptlist{-mbranch-cost=@var{N-instruction} @gol
>> +-mmemcpy -mno-memcpy @gol
>> +-mplt -mno-plt @gol
>> +-mabi=@var{ABI-string} @gol
>> +-mfdiv -mno-fdiv @gol
>> +-mdiv -mno-div @gol
>> +-march=@var{ISA-string} @gol
>> +-mtune=@var{processor-string} @gol
>> +-msmall-data-limit=@var{N-bytes} @gol
>> +-msave-restore -mno-save-restore @gol
>> +-mcmodel=@var{code-model} @gol
>> +-mexplicit-relocs -mno-explicit-relocs @gol}
>
> Please use 2 spaces to separate options on the same line in @gccoptlist
> instead of only 1.
https://github.com/riscv/riscv-gcc/commit/7b6385fe73a38221bfbc2a2f7983a266960f7ea4
>> @@ -13881,6 +13895,7 @@ platform.
>> * PowerPC Options::
>> * RL78 Options::
>> * RS/6000 and PowerPC Options::
>> +* RISC-V Options::
>> * RX Options::
>> * S/390 and zSeries Options::
>> * Score Options::
>
> Can we please keep this properly alphabetized? Likewise with the
> placement of the section itself.
https://github.com/riscv/riscv-gcc/commit/8a64242d0d0b90707e84368fcafeefc1b73c1311
Thanks for the feedback!