This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libgomp: Normalize the names of a few functions of the libgomp plugin API (was: libgomp: Provide prototypes for functions implemented by libgomp plugins)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 2 Feb 2017 13:27:11 +0100
- Subject: Re: libgomp: Normalize the names of a few functions of the libgomp plugin API (was: libgomp: Provide prototypes for functions implemented by libgomp plugins)
- Authentication-results: sourceware.org; auth=none
- References: <874m0kx3l5.fsf@hertz.schwinge.homeip.net> <20170127092842.GS1867@tucnak> <87efzjuw4h.fsf@hertz.schwinge.homeip.net> <87bmuku6ia.fsf@hertz.schwinge.homeip.net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Feb 02, 2017 at 01:22:37PM +0100, Thomas Schwinge wrote:
> Hi!
>
> On Tue, 31 Jan 2017 15:44:46 +0100, I wrote:
> > --- libgomp/libgomp.h
> > +++ libgomp/libgomp.h
> > @@ -882,31 +882,35 @@ typedef struct acc_dispatch_t
>
> > + __typeof (GOMP_OFFLOAD_openacc_parallel) *exec_func;
>
> As can be seen here, for a handful of functions, the name of the
> implementation in the plugins ("GOMP_OFFLOAD_openacc_parallel") doesn't
> match the name used in libgomp proper ("openacc.exec_func"). Here is a
> patch to adjust these. OK for trunk? If not now, then in next stage 1?
Ok for trunk now, otherwise we'd have to bump the plugin interface in GCC8, even
when we don't know if we'll need to do that.
Jakub