This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PGO bootstrap on x390x (PR bootstrap/78985).
- From: Jeff Law <law at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Richard Biener <richard dot guenther at gmail dot com>
- Date: Tue, 31 Jan 2017 09:40:51 -0700
- Subject: Re: [PATCH] Fix PGO bootstrap on x390x (PR bootstrap/78985).
- Authentication-results: sourceware.org; auth=none
- References: <08fd2591-2e9b-7b62-aa85-f2ef57efa947@suse.cz>
On 01/30/2017 04:27 AM, Martin Liška wrote:
Hi.
Following patch simply fixes issues reported by -Wmaybe-unitialized. That enables PGO bootstrap
on a s390x machine.
Ready to be installed?
Martin
0001-Fix-PGO-bootstrap-on-x390x-PR-bootstrap-78985.patch
From 3f3c3fe790ebffd038a033b6946de663e2305574 Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Mon, 30 Jan 2017 11:09:29 +0100
Subject: [PATCH] Fix PGO bootstrap on x390x (PR bootstrap/78985).
gcc/ChangeLog:
2017-01-30 Martin Liska <mliska@suse.cz>
PR bootstrap/78985
* config/s390/s390.c (s390_gimplify_va_arg): Initialize local
variable to NULL.
Odds are jump threading didn't want do duplicate this code due to better
CFG profile data:
/* ... Otherwise out of the overflow area. */
t = ovf;
if (size < UNITS_PER_LONG && !left_align_p)
t = fold_build_pointer_plus_hwi (t, UNITS_PER_LONG - size);
gimplify_expr (&t, pre_p, NULL, is_gimple_val, fb_rvalue);
gimplify_assign (addr, t, pre_p);
if (size < UNITS_PER_LONG && left_align_p)
t = fold_build_pointer_plus_hwi (t, UNITS_PER_LONG);
else
t = fold_build_pointer_plus_hwi (t, size);
gimplify_assign (ovf, t, pre_p);
As a result of not duplicating that code we don't thread the reg !=
NULL_TREE that guards the lab_over use.
OK for the trunk,
jeff