This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add AVX512 k-mask intrinsics
On 26 Jan 13:05, Jakub Jelinek wrote:
> On Thu, Jan 26, 2017 at 03:53:44AM -0800, Kirill Yukhin wrote:
> > Hi,
> > On 26 Jan 12:49, Thomas Schwinge wrote:
> > > Hi!
> > >
> > > On Thu, 26 Jan 2017 02:44:56 -0800, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> > > > On 26 Jan 10:14, Thomas Schwinge wrote:
> > > > > I see:
> > > > >
> > > > > {+FAIL: gcc.target/i386/avx512f-ktestw-2.c (test for excess errors)+}
> > > > > {+UNRESOLVED: gcc.target/i386/avx512f-ktestw-2.c compilation failed to produce executable+}
> > > > >
> > > > > ... because of:
> > > > >
> > > > > /tmp/ccjv3mX2.s: Assembler messages:
> > > > > /tmp/ccjv3mX2.s:26: Error: no such instruction: `ktestw %k1,%k0'
> > > > > compiler exited with status 1
> > > > Which version of gas do you use?
> > >
> > > A rather old one on that Ubuntu 12.10 system:
> > >
> > > $ as --version
> > > GNU assembler (GNU Binutils for Ubuntu) 2.22.90.20120924
> > > [...]
> > >
> > > > It should be OK since v2.25.
> > >
> > > OK, but as done for other tests, for older versions such testing then
> > > should be UNSUPPORTED instead of FAIL/UNRESOLVED (as long as that is
> > > practicable, which has already been described how to do, as I understand
> > > the other messages).
> > This is a bug as Uroš properly mentioned. Will fix.
>
> Like this? Tested on x86_64-linux. Ok for trunk?
You're too fast. I did exactly the same.
OK for trunk.
--
Thanks, K
>
> 2017-01-26 Jakub Jelinek <jakub@redhat.com>
>
> * config/i386/avx512fintrin.h (_ktest_mask16_u8,
> _ktestz_mask16_u8, _ktestc_mask16_u8, _kadd_mask16): Move to ...
> * config/i386/avx512dqintrin.h (_ktest_mask16_u8,
> _ktestz_mask16_u8, _ktestc_mask16_u8, _kadd_mask16): ... here.
> * config/i386/i386-builtin.def (__builtin_ia32_ktestchi,
> __builtin_ia32_ktestzhi, __builtin_ia32_kaddhi): Use
> OPTION_MASK_ISA_AVX512DQ instead of OPTION_MASK_ISA_AVX512F.
> * config/i386/sse.md (SWI1248_AVX512BWDQ2): New mode iterator.
> (kadd<mode>, ktest<mode>): Use it instead of SWI1248_AVX512BWDQ.
> testsuite/
> * gcc.target/i386/avx512f-kaddw-1.c: Renamed to ...
> * gcc.target/i386/avx512dq-kaddw-1.c: ... this. New test. Replace
> avx512f with avx512dq.
> * gcc.target/i386/avx512f-ktestw-1.c: Renamed to ...
> * gcc.target/i386/avx512dq-ktestw-1.c: ... this. New test. Replace
> avx512f with avx512dq.
> * gcc.target/i386/avx512f-ktestw-2.c: Renamed to ...
> * gcc.target/i386/avx512dq-ktestw-2.c: ... this. New test. Replace
> avx512f with avx512dq.
>