This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add AVX512 k-mask intrinsics

From: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
To: Kirill Yukhin <kirill dot yukhin at gmail dot com>, Richard Biener <rguenther at suse dot de>
Cc: Uros Bizjak <ubizjak at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 20 Jan 2017 23:03:53 +0300
Subject: Re: [PATCH] Add AVX512 k-mask intrinsics
Authentication-results: sourceware.org; auth=none
References: <CAMXFM3uiLynWanig52BfJa47qdKwffdYgqHfnC7yT4bJrsiO5A@mail.gmail.com> <20170117123005.GA16946@ubuntu> <CAMXFM3sta7549Vwq-n_B_iuaHxS_XGCKHHaHsMgcwWXAmrC8zQ@mail.gmail.com> <20170117135102.GY1867@tucnak> <CAMXFM3sOT+QWaH==NPo8h4SCiYk82fO9bibN+5G1B4Etp6_h1w@mail.gmail.com> <20170119103859.GA35306@ubuntu> <CAMXFM3vLdWVF2CQTcz=g1h5ic8Lx3AzxG3P+vebPjOCg_jBMHQ@mail.gmail.com> <20170119175506.GA5570@ubuntu> <CAMXFM3vDTzDpZOJEPowfmcFSKvwGCO6dGnZrc8SpmFHdjcuayA@mail.gmail.com> <CAFULd4bwOe8uTLck4kbMji2LAmtmJ7sjW5GGg-ikM3dcSjKHXw@mail.gmail.com> <20170120170801.GA3718@ubuntu>

2017-01-20 20:08 GMT+03:00 Kirill Yukhin <kirill.yukhin@gmail.com>:
> Hi,
> On 20 Jan 14:46, Uros Bizjak wrote:
>> On Fri, Jan 20, 2017 at 2:32 PM, Andrew Senkevich
>> <andrew.n.senkevich@gmail.com> wrote:
>>
>> > here is intrinsics for ktest{b,w,d,q} and kortest{b,w,d,q}. Is it Ok?
>> >
>> > gcc/
>> >     * config/i386/avx512bwintrin.h: Add k-mask test, kortest intrinsics.
>> >     * config/i386/avx512dqintrin.h: Ditto.
>> >     * config/i386/avx512fintrin.h: Ditto.
>> >     * gcc/config/i386/i386.c: Handle new builtins.
>> >     * config/i386/i386-builtin.def: Add new builtins.
>> >     * config/i386/sse.md (ktest<mode>, kortest<mode>): New.
>> >     (UNSPEC_KORTEST, UNSPEC_KTEST): New.
>> >
>> > gcc/testsuite/
>> >     * gcc.target/i386/avx512bw-ktestd-1.c: New test.
>> >     * gcc.target/i386/avx512bw-ktestq-1.c: Ditto.
>> >     * gcc.target/i386/avx512dq-ktestb-1.c: Ditto.
>> >     * gcc.target/i386/avx512f-ktestw-1.c: Ditto.
>> >     * gcc.target/i386/avx512bw-kortestd-1.c: Ditto.
>> >     * gcc.target/i386/avx512bw-kortestq-1.c: Ditto.
>> >     * gcc.target/i386/avx512dq-kortestb-1.c: Ditto.
>> >     * gcc.target/i386/avx512f-kortestw-1.c: Ditto.
>>
>> IMO, you should add some runtime tests.
> +1
>
>> Otherwise, the patch LGTM, but I'l leave the final approval to Kirill.
> Anyway trunk is frozen, so I suppose you'll need OK from RM.

Kirill, attached with runtime tests.

Richard, are you OK to approve commit of this patch?
It is last part of k-mask intrinsics, it would be great to have all
intrinsics of this type available in single GCC release..

Updated changelog:

gcc/
    * config/i386/avx512bwintrin.h: Add k-mask test, kortest intrinsics.
    * config/i386/avx512dqintrin.h: Ditto.
    * config/i386/avx512fintrin.h: Ditto.
    * gcc/config/i386/i386.c: Handle new builtins.
    * config/i386/i386-builtin.def: Add new builtins.
    * config/i386/sse.md (ktest<mode>, kortest<mode>): New.
    (UNSPEC_KORTEST, UNSPEC_KTEST): New.

gcc/testsuite/
    * gcc.target/i386/avx512bw-ktestd-1.c: New test.
    * gcc.target/i386/avx512bw-ktestq-1.c: Ditto.
    * gcc.target/i386/avx512dq-ktestb-1.c: Ditto.
    * gcc.target/i386/avx512f-ktestw-1.c: Ditto.
    * gcc.target/i386/avx512bw-kortestd-1.c: Ditto.
    * gcc.target/i386/avx512bw-kortestq-1.c: Ditto.
    * gcc.target/i386/avx512dq-kortestb-1.c: Ditto.
    * gcc.target/i386/avx512f-kortestw-1.c: Ditto.
    * gcc.target/i386/avx512bw-ktestd-2.c: Ditt
    * gcc.target/i386/avx512bw-ktestq-2.c: Ditto.
    * gcc.target/i386/avx512dq-ktestb-2.c: Ditto.
    * gcc.target/i386/avx512f-ktestw-2.c: Ditto.
    * gcc.target/i386/avx512bw-kortestd-2.c: Ditto.
    * gcc.target/i386/avx512bw-kortestq-2.c: Ditto.
    * gcc.target/i386/avx512dq-kortestb-2.c: Ditto.
    * gcc.target/i386/avx512f-kortestw-2.c: Ditto.


--
WBR,
Andrew

Attachment: avx512-kmask-intrin-part5.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Richard Biener
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Kirill Yukhin
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Thomas Schwinge

References:
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Andrew Senkevich
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Kirill Yukhin
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Andrew Senkevich
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Jakub Jelinek
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Andrew Senkevich
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Kirill Yukhin
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Andrew Senkevich
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Kirill Yukhin
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Andrew Senkevich
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Uros Bizjak
- Re: [PATCH] Add AVX512 k-mask intrinsics
  - From: Kirill Yukhin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]