This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add AVX512 k-mask intrinsics
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: Kirill Yukhin <kirill dot yukhin at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 20 Jan 2017 14:46:07 +0100
- Subject: Re: [PATCH] Add AVX512 k-mask intrinsics
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4Z16_wQvOMLQPRxQjyom7fMHnaYabwXqcaezrp1in8gyg@mail.gmail.com> <CAMXFM3sCm43CE+N+Nf39RaytCz1Uc=XBKa=o8qd0DkL=_sfCnw@mail.gmail.com> <20170116225500.GT1867@tucnak> <CAMXFM3uiLynWanig52BfJa47qdKwffdYgqHfnC7yT4bJrsiO5A@mail.gmail.com> <20170117123005.GA16946@ubuntu> <CAMXFM3sta7549Vwq-n_B_iuaHxS_XGCKHHaHsMgcwWXAmrC8zQ@mail.gmail.com> <20170117135102.GY1867@tucnak> <CAMXFM3sOT+QWaH==NPo8h4SCiYk82fO9bibN+5G1B4Etp6_h1w@mail.gmail.com> <20170119103859.GA35306@ubuntu> <CAMXFM3vLdWVF2CQTcz=g1h5ic8Lx3AzxG3P+vebPjOCg_jBMHQ@mail.gmail.com> <20170119175506.GA5570@ubuntu> <CAMXFM3vDTzDpZOJEPowfmcFSKvwGCO6dGnZrc8SpmFHdjcuayA@mail.gmail.com>
On Fri, Jan 20, 2017 at 2:32 PM, Andrew Senkevich
<andrew.n.senkevich@gmail.com> wrote:
> here is intrinsics for ktest{b,w,d,q} and kortest{b,w,d,q}. Is it Ok?
>
> gcc/
> * config/i386/avx512bwintrin.h: Add k-mask test, kortest intrinsics.
> * config/i386/avx512dqintrin.h: Ditto.
> * config/i386/avx512fintrin.h: Ditto.
> * gcc/config/i386/i386.c: Handle new builtins.
> * config/i386/i386-builtin.def: Add new builtins.
> * config/i386/sse.md (ktest<mode>, kortest<mode>): New.
> (UNSPEC_KORTEST, UNSPEC_KTEST): New.
>
> gcc/testsuite/
> * gcc.target/i386/avx512bw-ktestd-1.c: New test.
> * gcc.target/i386/avx512bw-ktestq-1.c: Ditto.
> * gcc.target/i386/avx512dq-ktestb-1.c: Ditto.
> * gcc.target/i386/avx512f-ktestw-1.c: Ditto.
> * gcc.target/i386/avx512bw-kortestd-1.c: Ditto.
> * gcc.target/i386/avx512bw-kortestq-1.c: Ditto.
> * gcc.target/i386/avx512dq-kortestb-1.c: Ditto.
> * gcc.target/i386/avx512f-kortestw-1.c: Ditto.
IMO, you should add some runtime tests.
Otherwise, the patch LGTM, but I'l leave the final approval to Kirill.
Uros.