This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Kito Cheng <kito dot cheng at gmail dot com>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Kuan-Lin Chen <kuanlinchentw at gmail dot com>, "clm at codesourcery dot com" <clm at codesourcery dot com>, Andrew Waterman <andrew at sifive dot com>, Palmer Dabbelt <palmer at dabbelt dot com>
- Date: Tue, 17 Jan 2017 11:13:07 +0100
- Subject: Re: [PATCH] PR79079 Fix __builtin_mul_overflow code gen for !TRULY_NOOP_TRUNCATION target
- Authentication-results: sourceware.org; auth=none
- References: <CA+yXCZDNijzskL8f6MrDXA3RqdUNknE0meZzCEorkSAHuKHpsA@mail.gmail.com> <20170116074038.GJ1867@tucnak> <6D39441BF12EF246A7ABCE6654B0235380B2A3CD@HHMAIL01.hh.imgtec.org> <CA+yXCZAaKdh4=ADUuEHTqJ+pTjzZY30wA_E7vYDXN4-7RpwRDA@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Jan 17, 2017 at 06:09:29PM +0800, Kito Cheng wrote:
> Hi Jakub:
>
> Thanks for your review, attachment is v2 patch, it's also run
> regression with x86-64, mips64, riscv64 and riscv32.
> and additional, I've run gcc 6 branch with this patch, fix mips64 and
> riscv64 and no
> introduce new regression on x86-64 and riscv32 on 6/trunk, it's ok for
> trunk and gcc-6-branch ?
>
> gcc/ChangeLog:
>
> 2017-01-16 Kito Cheng <kito.cheng@gmail.com>
> Kuan-Lin Chen <kuanlinchentw@gmail.com>
>
> PR target/PR79079
> * internal-fn.c (expand_mul_overflow): Use convert_modes instead of
> gen_lowpart.
Ok for trunk, for gcc-6-branch only after say 2 weeks on the trunk without
problems.
Jakub