This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [ping] 3 aarch64/arm/rs6000 patches
- From: Alan Modra <amodra at gmail dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>, Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 17 Jan 2017 18:30:53 +1030
- Subject: Re: [ping] 3 aarch64/arm/rs6000 patches
- Authentication-results: sourceware.org; auth=none
- References: <2384369.JtBCaDPbPu@polaris>
On Mon, Jan 16, 2017 at 09:26:53AM +0100, Eric Botcazou wrote:
> rs6000 (Fix reload failures in 64-bit mode):
> https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00568.html
The one thing I find questionable about this patch is that it will set
mem_alias_set for the resulting MEMs to the TOC alias set. Is that
correct for memory not in the TOC?
My guess is that in this case it is OK, because you're handling
constants forced to memory. By giving them a non-zero alias set
you're saying that they won't alias other mem accesses, which should
be true.
I'm commenting because when you first posted the patch, Segher asked
me whether I had any concerns and I replied with the first paragraph
or something like it. So I'm probably partly to blame for the delay
in review. The second paragraph is me rethinking that concern.
--
Alan Modra
Australia Development Lab, IBM