This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Optimize away useless snprintf calls with -fprintf-return-value (take 2)

From: Jeff Law <law at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>, Martin Sebor <msebor at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 12 Jan 2017 14:19:53 -0700
Subject: Re: [PATCH] Optimize away useless snprintf calls with -fprintf-return-value (take 2)
Authentication-results: sourceware.org; auth=none
References: <20170102200456.GL21933@tucnak> <a0321123-86e2-16d5-3aab-6f37329e6cdb@gmail.com> <20170110072357.GV21933@tucnak>

On 01/10/2017 12:23 AM, Jakub Jelinek wrote:

On Mon, Jan 02, 2017 at 04:54:57PM -0700, Martin Sebor wrote:

Looks good to me, thanks!  Just a couple of suggestions:


Here is updated patch with those added comments (and adjusted for the
current trunk).  Ok for trunk?

2017-01-10  Jakub Jelinek  <jakub@redhat.com>

	* gimple-ssa-sprintf.c (try_substitute_return_value): Remove
	info.nowrite calls with no lhs that can't throw.  Return bool
	whether gsi_remove has been called or not.
	(pass_sprintf_length::handle_gimple_call): Return bool whether
	try_substitute_return_value called gsi_remove.  Formatting fix.
	(pass_sprintf_length::execute): Don't use gsi_remove if
	handle_gimple_call returned true.

	* gcc.dg/tree-ssa/builtin-snprintf-1.c: New test.

OK.
jeff

References:
- [PATCH] Optimize away useless snprintf calls with -fprintf-return-value
  - From: Jakub Jelinek
- Re: [PATCH] Optimize away useless snprintf calls with -fprintf-return-value
  - From: Martin Sebor
- [PATCH] Optimize away useless snprintf calls with -fprintf-return-value (take 2)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]