Re: [PATCH] Fix late dwarf generated early from optimized out globals

[Andreas Tobler <andreast-list at fgznet dot ch>]

On 09.01.17 12:25, Jakub Jelinek wrote:
> On Mon, Jan 09, 2017 at 11:53:38AM +0100, Richard Biener wrote:
> > > Ok, attached the part I bootstrapped successfully on amd64-*-freebsd12 and
> > > aarch64-*-freebsd12. From the amd64 run you'll find some test results at the
> > > usual place. The aarch64 run takes some more time.
> > >
> > > I hope I got it right this time :)
> > > What do you think?
> >
> > Looks good to me with the added comment to dwarf2out_late_global_decl
> > exchanged to the one on trunk.
>
> The formatting is completely wrong.
> Lines indented e.g. by 7 spaces (or tab + 1/3 space(s)),
> /* comment inside of { block starting in the same column as {
> (should be 2 columns to the right), && ! not aligned below VAR_P,
> or indenting by 3 columns instead of 2.

Hehe, yep. This time done with emacs ;)

Here the hopefully final patch with proper ChangeLog and formatting fixed.

Ok to apply?

Thanks,
Andreas

2017-01-09  Andreas Tobler  <andreast@gcc.gnu.org>

	Backport from mainline
	2016-09-19  Richard Biener  <rguenther@suse.de>

	* dwarf2out.c (dwarf2out_late_global_decl): When being during the
	early debug phase do not add locations but only const value
	attributes.

	Backport from mainline
	2016-10-20  Richard Biener  <rguenther@suse.de>

	* cgraphunit.c (analyze_functions): Set node->definition to
	false to signal symbol removal to debug_hooks->late_global_decl.

Attachment: gcc6_backport_fix.diff
Description: Text document