This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] Reenable RTL sharing verification
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>, Jeff Law <law at redhat dot com>, Bernd Schmidt <bschmidt at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 30 Nov 2016 13:08:31 +0100
- Subject: [PATCH] Reenable RTL sharing verification
- Authentication-results: sourceware.org; auth=none
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
Hi!
The http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01055.html
change broke all RTL sharing verification, even with --enable-checking=rtl
we don't verify anything for the last 3.5 years.
Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux together
with the previously posted 2 patches, ok for trunk if those 2 are approved?
Can people try --enable-checking=rtl on more targets?
2016-11-30 Jakub Jelinek <jakub@redhat.com>
* emit-rtl.c (verify_insn_sharing): Call verify_rtx_sharing instead of
reset_used_flags.
--- gcc/emit-rtl.c.jj 2016-11-23 16:47:35.000000000 +0100
+++ gcc/emit-rtl.c 2016-11-30 10:04:59.691135836 +0100
@@ -2826,10 +2826,10 @@ static void
verify_insn_sharing (rtx insn)
{
gcc_assert (INSN_P (insn));
- reset_used_flags (PATTERN (insn));
- reset_used_flags (REG_NOTES (insn));
+ verify_rtx_sharing (PATTERN (insn), insn);
+ verify_rtx_sharing (REG_NOTES (insn), insn);
if (CALL_P (insn))
- reset_used_flags (CALL_INSN_FUNCTION_USAGE (insn));
+ verify_rtx_sharing (CALL_INSN_FUNCTION_USAGE (insn), insn);
}
/* Go through all the RTL insn bodies and check that there is no unexpected
Jakub