This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR fortran/78479 -- allocate a charlen

From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
To: Janus Weil <janus at gcc dot gnu dot org>
Cc: kargl at uw dot edu, gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 22 Nov 2016 13:46:46 -0800
Subject: Re: [PATCH] PR fortran/78479 -- allocate a charlen
Authentication-results: sourceware.org; auth=none
References: <20161122205557.GA92090@troutmask.apl.washington.edu> <CAKwh3qj6v3-3GLGwWUWjrYdvuUowLDjNTjw+ONcTaZ7XnkdyDw@mail.gmail.com>
Reply-to: kargl at uw dot edu

On Tue, Nov 22, 2016 at 10:21:52PM +0100, Janus Weil wrote:
> 
> > The patch and ChangeLog shuod be sufficient to explain the change.
> > Regression tested on x86_64-*-freebsd.  OK to commit?
> 
> the patch itself looks good.
> 

Thanks.

> For the test case, I'd prefer a somewhat more meaningful name (e.g.
> char_component_initializer_3.f90 or similar) and a mention of the PR
> number in a comment inside the test case.

At one time, I also preferred a meaningful name, but have
changed over time to using the PR number as the name.  There
are various pros and cons for using the PR number as the name.
In this, as char*_[1,2].f90 already exist, I rename the testcase.

-- 
Steve

References:
- [PATCH] PR fortran/78479 -- allocate a charlen
  - From: Steve Kargl
- Re: [PATCH] PR fortran/78479 -- allocate a charlen
  - From: Janus Weil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]