This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] HSA specific built-ins

On Fri, Nov 18, 2016 at 11:27:24AM +0100, Jakub Jelinek wrote:
> On Sun, Nov 13, 2016 at 08:39:35PM +0100, Martin Jambor wrote:
> > Hello,
> > 
> > this patch adds a small file hsa-builtins.def which defines a few
> > builtins that I then use in OpenMP lowering and expansion.
> > 
> > After we split gridification stuff in omp-low.c to a separate file, we
> > should be able to only conditionally include the file and remove the
> > weird conditional ifdef.
> > 
> > OK for trunk?
> 
> Does this work well even with lto and jit FEs?  Ok for trunk if it does.

I have enabled jit, ran its testsuite and compared the results to ones
from unpatched trunk and found no new failures.  I have also
lto-bootstrapped the patch with both hsa enabled and disabled so that
should be fine too.  Thus, I consider the patch approved.

Thank you very much,

Martin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]