This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [libstdc++, testsuite] Add dg-require-thread-fence
- From: Mike Stump <mikestump at comcast dot net>
- To: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- Cc: Christophe Lyon <christophe dot lyon at linaro dot org>, Jonathan Wakely <jwakely at redhat dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 14 Nov 2016 12:48:52 -0800
- Subject: Re: [libstdc++, testsuite] Add dg-require-thread-fence
- Authentication-results: sourceware.org; auth=none
- References: <CAKdteObWfMso8e5R_eE=q=_ROD7nkmKphVM1=-zk_J1j+As3LA@mail.gmail.com> <20161020094008.GB2922@redhat.com> <CAKdteObZBtji1Yc+aEH0JHQRX2HcrgePrVTGUApzAmqPEiTM6A@mail.gmail.com> <20161020122040.GI2922@redhat.com> <A7E1F0A3-E50E-4A8E-BE67-15FA61633C6B@comcast.net> <20161020163417.GL2922@redhat.com> <CAKdteOYAwyeo9xWV8ji+J_Lh-TS2KS71z1eeLvVjLN91EK090w@mail.gmail.com> <341FEC7E-6E51-4EFC-AD91-D4B708DC7011@comcast.net> <CAKdteOacymxhSZVAwe8axFWr8nzrTHnc5d+pDOy=H9x=Vh23NA@mail.gmail.com> <CAJA7tRbeR-z-NZgk72odwPM=iUzQq5G18i8qMgvQ9hX7QOZL+w@mail.gmail.com>
On Nov 14, 2016, at 12:31 PM, Ramana Radhakrishnan <ramana.gcc@googlemail.com> wrote:
>
> https://sourceware.org/ml/newlib/2015/msg00653.html
I think that patch is wrong. It is wrong to warn on a system where an empty body is correct. It is wrong to warn when something more than nothing needs to be done. In short, it is never right.
If you implement what is required for any machine (configuration), at least it will be right for that configuration. Others where that isn't correct, can then implement what is correct for their machine (configuration), if you cannot.