This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 00/11] more rtx_insn * stuff
On Mon, Nov 14, 2016 at 02:45:40PM +0100, Bernd Schmidt wrote:
> On 11/14/2016 09:09 AM, tbsaunde+gcc@tbsaunde.org wrote:
> > From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> >
> > Hi,
> >
> > Basically $subject which gets rid of a few more casts over all.
> >
> > I ment to get this out a little while back, but life got busy, and I didn't
> > read the status announcement properly, so virtually working from hawaii for
> > now. patches individually built and regtested on x86_64-linux-gnu, and series
> > run through config-list.mk, ok?
>
> Ok for all except #3 and #11.
>
> For #3, I just don't like increasing indentation like that, I prefer to just
> declare the variable earlier.
ok, fine.
> #11 does unexplained things with dyn_casts (why not as_a?) and templates.
sorry, I really should have explained that. For some reason we were
missing a is_a_helper specialization to test if a const_rtx is a
rtx_call_insn *, we have ones for things like const_rtx to const
rtx_insn *, but not const rtx_call_insn *. So I added that which is the
template stuff. I used dyn_cast because its the same as if (is_a<x> ())
as_a<x> (), but in this case its shorter than writing that out. Of
course I could use is_a and as_a if that seems clearer.
Trev
>
> Bernd