This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [WIP C++ PATCH] P0217R3 - C++17 structured bindings
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 14 Nov 2016 15:30:26 +0100
- Subject: Re: [WIP C++ PATCH] P0217R3 - C++17 structured bindings
- Authentication-results: sourceware.org; auth=none
- References: <20161109122422.GX3541@tucnak.redhat.com> <CADzB+2m=6o2qL0du97sYdDwZbH-1YsZhFgv4kQxTm2wDOU_Twg@mail.gmail.com>
On Mon, Nov 14, 2016 at 6:04 AM, Jason Merrill <jason@redhat.com> wrote:
> On Wed, Nov 9, 2016 at 7:24 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> The match.pd hunk is needed, otherwise the generic folding happily folds
>> int arr[2];
>> ...
>> auto [ x, y ] = arr;
>> &x == &arr[0]
>> into 0, because it thinks x and arr are distinct VAR_DECLs. Though, if
>> such comparisons are required to be folded in constexpr contexts under
>> certain conditions, we'd need to handle the DECL_VALUE_EXPRs in constexpr.c
>> somehow.
>
> What do you think of this approach instead?
get_addr_base_and_unit_offset_1 is infrastructure related to
get_ref_base_and_extent,
get_inner_reference and get_base_address. All of those should really
behave the same
with respect to the innermost decl.
Thus I don't think we should handle this here.
Richard.