This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [fixincludes] Fix macOS 10.12 <AvailabilityInternal.h> and <os/trace.h> (PR sanitizer/78267)


> On 11 Nov 2016, at 16:50, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
> 
> Hi Iain,
> 
>>> On 11 Nov 2016, at 11:18, Mike Stump <mikestump@comcast.net> wrote:
>>> 
>>> On Nov 11, 2016, at 2:15 AM, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote:
>>>> The patch passes fixincludes make check (this time for real ;-) and
>>>> restores macOS 10.12 bootstrap.
>>> 
>>> No objections from me.
>> 
>> On x86_64-darwin14, there still seem to be fails
>> 
>> /usr/include/os/base.h 
>> /usr/include/dispatch/dispatch.h
>> /usr/include/dispatch/object.h
>> 
>> of kinds __has_extension() and block syntax.
>> 
>> (I haven’t had a chance to check any other OS revs yet).
> 
> I don't have access to anything but Darwin 11 and 16, so I can't help
> directly.

OK. Only the dispatch/ ones are present on Darwin11

 (did that bootstrap OK for you? if so likely 10.6 will be OK too - save me checking).

>  Maybe, if you can send (or attach to the PR) the specific
> errors and problematic headers (or point to copies on
> opensource.apple.com), I can help with the fixincludes part.

I don’t have a Darwin16 system live at present, so can’t compare, but os/base.h is present on Darwin15 (so i’d expect it to be in the Darwin16 SDK)

I’ll see if I can take an initial pass at it over the w/e and post to the PR.

Iain



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]