This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [IPCP] Remove unreachable code

From: Jeff Law <law at redhat dot com>
To: kugan <kugan dot vivekanandarajah at linaro dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: Prathamesh Kulkarni <prathamesh dot kulkarni at linaro dot org>, Jan Hubicka <hubicka at ucw dot cz>, Martin Jambor <mjambor at suse dot cz>
Date: Fri, 4 Nov 2016 20:44:55 -0600
Subject: Re: [IPCP] Remove unreachable code
Authentication-results: sourceware.org; auth=none
References: <9a16aa02-ca87-48a9-562d-aa9042356260@linaro.org>

On 10/24/2016 04:46 PM, kugan wrote:

Hi,

I noticed that in ipcp_bits_lattice::meet_with we have:

  else if (TREE_CODE_CLASS (code) == tcc_unary)
  ....
  else if (code == NOP_EXPR)
  ....

Since TREE_CODE_CLASS for NOP_EXPR is tcc_unary, if (code == NOP_EXPR)
is unreachable and therefore removing it. I also don't think that we
need any special casing for NOP_EXPR here. bit_value_unop handles
already handles CASE_CONVERT.

Is this OK if no regressions in bootstrap and regression testing.

Thanks,
Kugan




gcc/ChangeLog:

2016-10-25  Kugan Vivekanandarajah  <kuganv@linaro.org>

    * ipa-cp.c (ipcp_bits_lattice::meet_with): Remove unreachable code.

OK.
jeff

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]