This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, testsuite] Add new effective-target_store_merge
- From: Mike Stump <mikestump at comcast dot net>
- To: Senthil Kumar Selvaraj <senthil_kumar dot selvaraj at atmel dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 3 Nov 2016 09:58:48 -0700
- Subject: Re: [Patch, testsuite] Add new effective-target_store_merge
- Authentication-results: sourceware.org; auth=none
- References: <87wpgkzzbp.fsf@atmel.com>
On Nov 3, 2016, at 2:29 AM, Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com> wrote:
>
> The below patch adds a new effective target keyword (store_merge) for
> use in the store_merging_xxx.c tests.
>
> The tests currently require non_strict_align, but they still fail for the avr.
> Eyeballing the dump, I found that the pass doesn't attempt merging as it is
> unprofitable for a target like the avr which has only single byte
> stores.
>
> I figured store merging is unlikely to be profitable for targets with
> smallish word sizes, and added a check_effective_target_store_merge
> that combines non_strict_align and int32plus.
>
> Is this ok for trunk?
Ok.
If anyone knows of a reason why this would turn off these tests for a target that currently tests them and works ok, let us know.