This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gcc-patches at gcc dot gnu dot org
- Cc: Jeff Law <law at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Thu, 3 Nov 2016 13:01:32 +0100
- Subject: Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.
- Authentication-results: sourceware.org; auth=none
- References: <cover.1465577682.git.andrew.burgess@embecosm.com> <a3ed605cdecc22d1c5ff91d90b4856574fea2139.1465577682.git.andrew.burgess@embecosm.com> <512a967c-39c4-44f5-6f24-d75ef543979d@redhat.com> <20160629192130.GF8823@embecosm.com> <20160914130048.GC31794@embecosm.com>
On 09/14/2016 03:00 PM, Andrew Burgess wrote:
In an attempt to get this patch merged (as I still think that its
correct) I've investigated, and documented a little more about how I
think things currently work. I'm sure most people reading this will
already know this, but hopefully, if my understanding is wrong someone
can point it out.
gcc/ChangeLog:
* gcc/bb-reorder.c: Remove 'toplev.h' include.
(pass_partition_blocks::gate): No longer check
user_defined_section_attribute, instead check the function decl
for a section attribute.
* gcc/c-family/c-common.c (handle_section_attribute): No longer
set user_defined_section_attribute.
* gcc/final.c (rest_of_handle_final): Likewise.
* gcc/toplev.c: Remove definition of user_defined_section_attribute.
* gcc/toplev.h: Remove declaration of
user_defined_section_attribute.
gcc/testsuiteChangeLog:
* gcc.dg/tree-prof/section-attr-1.c: New file.
* gcc.dg/tree-prof/section-attr-2.c: New file.
* gcc.dg/tree-prof/section-attr-3.c: New file.
I think the explanation is perfectly reasonable and the patch looks
good, except:
+__attribute__((noinline))
Add noclone to all of these as well.
Bernd