This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Implement -Wimplicit-fallthrough (version 9)
- From: Michael Matz <matz at suse dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Bernd Schmidt <bschmidt at redhat dot com>, Marek Polacek <polacek at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, Eric Botcazou <ebotcazou at adacore dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Markus Trippelsdorf <markus at trippelsdorf dot de>, Jason Merrill <jason at redhat dot com>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, Joseph Myers <joseph at codesourcery dot com>, Arnaud Charlet <charlet at adacore dot com>
- Date: Tue, 27 Sep 2016 15:56:10 +0200 (CEST)
- Subject: Re: Implement -Wimplicit-fallthrough (version 9)
- Authentication-results: sourceware.org; auth=none
- References: <20160920153343.GF19950@redhat.com> <20160927103941.GC307@x4> <20160927104750.GP7282@tucnak.redhat.com> <3281536.k3j4D4G97W@polaris> <CAFiYyc1ksRqxR81Q5fbeQ+sRpDsVN2qqVLfmf7W54LX50V-C-Q@mail.gmail.com> <a84b88e9-d6bd-31f4-a33e-1104531d7a22@redhat.com> <20160927115153.GU3223@redhat.com> <8521f44d-616c-a03d-879d-c400b13ce9d9@redhat.com> <20160927120108.GV3223@redhat.com> <6b5dbab6-0b5a-3f55-53e0-5dc419a3cd6a@redhat.com> <20160927134914.GW7282@tucnak.redhat.com>
Hi,
On Tue, 27 Sep 2016, Jakub Jelinek wrote:
> Just compare that to the number of real bugs the warning found in gcc
> codebase. It is really worth it for -Wextra.
All those bugs would also have been found as well when it had simply
accepted
/fall.*thr/i
anywhere in the preceding comment on one line. But all the recent
spelling changes of comments to cater for the strictness exactly shows how
misguided that is. The above would accept "Don't fall through" as well.
I say: so what?
Ciao,
Michael.