This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH GCC][v2]Simplify alias check code generation in vectorizer

On 2016.09.26 at 13:14 +0200, Richard Biener wrote:
> On Mon, Sep 26, 2016 at 11:21 AM, Robin Dapp <rdapp@linux.vnet.ibm.com> wrote:
> >> Comments added.  Bootstrap and test, is it reasonable?
> >
> > This introduces an ICE on s390x with a Fortran testcase, because
> > of an assertion failure in tree_to_uhwi (DR_STEP (dr_a.dr)) for
> > DR_STEP (dr_a.dr) = -8(OVF).
> >
> > The attached patch fixes this by introducing an additional
> > tree_fits_uhwi_p().
> >
> > ok to commit?
> 
> no, this disables handling of negative step.  I think it should
> check for tree_fits_shwi_p () instead and adjust the code to do
> 
>   unsigned HOST_WIDE_INT abs_step = absu_hwi (tree_to_shwi (DR_STEP (dr_a.dr)));
> 

And also please mention https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77724 and perhaps
add its testcase, too.

-- 
Markus
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]