Re: [PATCHv3][ARM] -mpure-code option for ARM

[Christophe Lyon <christophe dot lyon at linaro dot org>]

Hi Andre,


On 22 September 2016 at 19:04, Andre Vieira (lists)
<Andre.SimoesDiasVieira@arm.com> wrote:
> On 22/09/16 16:28, Richard Earnshaw (lists) wrote:
>> On 22/09/16 16:04, Andre Vieira (lists) wrote:
>>>
>>> I reworked the patch according to the comments above.
>>>
>>> Is this OK?
>>>
>>> gcc/ChangeLog:
>>> 2016-09-22  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>>             Terry Guo  <terry.guo@arm.com>
>>>
>>>         * target.def (elf_flags_numeric): New target hook.
>>>         * targhooks.h (default_asm_elf_flags_numeric): New.
>>>         * varasm.c (default_asm_elf_flags_numeric): New.
>>>           (default_elf_asm_named_section): Use new target hook.
>>>         * config/arm/arm.opt (mpure-code): New.
>>>         * config/arm/arm.h (SECTION_ARM_PURECODE): New.
>>>         * config/arm/arm.c (arm_asm_init_sections): Add section
>>>           attribute to default text section if -mpure-code.
>>>           (arm_option_check_internal): Diagnose use of option with
>>>           non supported targets and/or options.
>>>           (arm_asm_elf_flags_numeric): New.
>>>           (arm_function_section): New.
>>>           (arm_elf_section_type_flags): New.
>>>         * config/arm/elf.h (JUMP_TABLES_IN_TEXT_SECTION): Disable
>>>           for -mpure-code.
>>>         * gcc/doc/texi (TARGET_ASM_ELF_FLAGS_NUMERIC): New.
>>>         * gcc/doc/texi.in (TARGET_ASM_ELF_FLAGS_NUMERIC): Likewise.
>>>
>>>
>>>
>>> gcc/testsuite/ChangeLog:
>>> 2016-09-22  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>>             Terry Guo  <terry.guo@arm.com>
>>>
>>>         * gcc.target/arm/pure-code/ffunction-sections.c: New.
>>>         * gcc.target/arm/pure-code/no-literal-pool.c: New.
>>>         * gcc.target/arm/pure-code/pure-code.exp: New.
>>>
>>>
>>
>> I missed this last time around, but please can you wrap references to
>> SHF_ARM_PURECODE in the documentation with @code{...}.
>>
>> OK with that change.
>>
>> R.
>
> Done. Committed as revision r240379.
>
This patch broke the aarch64 builds:
/tmp/9380062_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/config/aarch64/aarch64.c:14391:
error: ‘hook_uint_uintp_false’ was not declared in this s
cope
/tmp/9380062_6.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/config/aarch64/aarch64.c:14391:
error: too many initializers for ‘gcc_target::asm_out’
make[2]: *** [aarch64.o] Error 1
make[2]: Leaving directory
`/tmp/9380062_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1/gcc'
make[1]: *** [all-gcc] Error 2
make[1]: Leaving directory
`/tmp/9380062_6.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/obj-aarch64-none-linux-gnu/gcc1'
make: *** [all] Error 2