This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Fix variant::operator= on references

From: Jonathan Wakely <jwakely at redhat dot com>
To: Tim Shen <timshen at google dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Ville Voutilainen <ville dot voutilainen at gmail dot com>
Date: Thu, 22 Sep 2016 11:59:14 +0100
Subject: Re: [Patch] Fix variant::operator= on references
Authentication-results: sourceware.org; auth=none
References: <CAG4ZjNn3pK3LhyPSRxVT1gzmmbBuCcjnqOtsP3ZOiXJM=eFcew@mail.gmail.com> <20160922083952.GT17376@redhat.com> <CAG4ZjN=4Rw8k_c-BqetSRLOJD-eQQazYmDi23m-6YoDY7x8kfQ@mail.gmail.com> <20160922100313.GW17376@redhat.com> <CAG4ZjNkQGBifkZeMnhCGujMSQhk11G_uPBFk10ozUKZwJPQvBA@mail.gmail.com> <CAG4ZjNnecr3yP0LDHM+YY9bZWtAAJk_c-sQo-9qeokmyZ0R=yw@mail.gmail.com>

On 22/09/16 03:40 -0700, Tim Shen wrote:

On Thu, Sep 22, 2016 at 3:36 AM, Tim Shen <timshen@google.com> wrote:

Then my question is, what about type traits uses like
is_copy_constructible? I have seen non-qualified uses in std::any and
std::optional and other places. Should all of them be qualified?


Ah never mind, I realized that *usually* a type trait use is not part
of a function call, so ADL is not triggered.


ADL is only used to do name lookup for unqualified functions, so it is
never necessary to qualify those types inside namespace std. Name
lookup will always find the right type.

References:
- [Patch] Fix variant::operator= on references
  - From: Tim Shen
- Re: [Patch] Fix variant::operator= on references
  - From: Jonathan Wakely
- Re: [Patch] Fix variant::operator= on references
  - From: Tim Shen
- Re: [Patch] Fix variant::operator= on references
  - From: Jonathan Wakely
- Re: [Patch] Fix variant::operator= on references
  - From: Tim Shen
- Re: [Patch] Fix variant::operator= on references
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]