This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Fix variant::operator= on references
- From: Tim Shen <timshen at google dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Date: Thu, 22 Sep 2016 03:36:18 -0700
- Subject: Re: [Patch] Fix variant::operator= on references
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNn3pK3LhyPSRxVT1gzmmbBuCcjnqOtsP3ZOiXJM=eFcew@mail.gmail.com> <20160922083952.GT17376@redhat.com> <CAG4ZjN=4Rw8k_c-BqetSRLOJD-eQQazYmDi23m-6YoDY7x8kfQ@mail.gmail.com> <20160922100313.GW17376@redhat.com>
On Thu, Sep 22, 2016 at 3:03 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
> On 22/09/16 01:49 -0700, Tim Shen wrote:
>>
>> Done. When writing the initial version, I was trying to save as much
>> qualifications as possible (as long as the semantic doesn't change)
>> for readability, but that might not be a good idea.
>
>
> It does change the semantics, as forward<_Tp>(__tp) can find another
> function via ADL (see the new test in this patch).
Then my question is, what about type traits uses like
is_copy_constructible? I have seen non-qualified uses in std::any and
std::optional and other places. Should all of them be qualified?
>
> Tested powerpc64le-linux, committed to trunk.
>
>
--
Regards,
Tim Shen