This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Add FALLTHRU to gimple-ssa-sprintf.c

From: Martin Sebor <msebor at gmail dot com>
To: Marek Polacek <polacek at redhat dot com>, Jakub Jelinek <jakub at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Martin Sebor <msebor at redhat dot com>
Date: Wed, 21 Sep 2016 08:56:26 -0600
Subject: Re: Add FALLTHRU to gimple-ssa-sprintf.c
Authentication-results: sourceware.org; auth=none
References: <20160921105233.GI19950@redhat.com> <20160921105723.GX7282@tucnak.redhat.com> <20160921110720.GJ19950@redhat.com>

On 09/21/2016 05:07 AM, Marek Polacek wrote:

On Wed, Sep 21, 2016 at 12:57:23PM +0200, Jakub Jelinek wrote:

On Wed, Sep 21, 2016 at 12:52:33PM +0200, Marek Polacek wrote:

Pointed out by Tobias.  This looks like a missing fallthru marker.

Ok?

2016-09-21  Marek Polacek  <polacek@redhat.com>

	* gimple-ssa-sprintf.c (pass_sprintf_length::compute_format_length):
	Add falls through comment.


This is obvious.


I wanted to give Martin a chance to comment, maybe it should've been
a break, but I'll commit this now.  Thanks.


Yes, falling through is intentional here and should have probably
been better documented.  Thanks for taking care of it!

Martin

References:
- Add FALLTHRU to gimple-ssa-sprintf.c
  - From: Marek Polacek
- Re: Add FALLTHRU to gimple-ssa-sprintf.c
  - From: Jakub Jelinek
- Re: Add FALLTHRU to gimple-ssa-sprintf.c
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]