This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Add FALLTHRU to gimple-ssa-sprintf.c
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Martin Sebor <msebor at redhat dot com>
- Date: Wed, 21 Sep 2016 12:57:23 +0200
- Subject: Re: Add FALLTHRU to gimple-ssa-sprintf.c
- Authentication-results: sourceware.org; auth=none
- References: <20160921105233.GI19950@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Sep 21, 2016 at 12:52:33PM +0200, Marek Polacek wrote:
> Pointed out by Tobias. This looks like a missing fallthru marker.
>
> Ok?
>
> 2016-09-21 Marek Polacek <polacek@redhat.com>
>
> * gimple-ssa-sprintf.c (pass_sprintf_length::compute_format_length):
> Add falls through comment.
This is obvious.
> diff --git gcc/gimple-ssa-sprintf.c gcc/gimple-ssa-sprintf.c
> index 0afcf68..dddb026 100644
> --- gcc/gimple-ssa-sprintf.c
> +++ gcc/gimple-ssa-sprintf.c
> @@ -2260,6 +2260,7 @@ pass_sprintf_length::compute_format_length (const call_info &info,
> case '\0':
> --pf;
> res->bounded = false;
> + /* FALLTHRU */
> case '%':
> spec.fmtfunc = format_percent;
> break;
>
> Marek
Jakub