This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Trevor Saunders <tbsaunde at tbsaunde dot org>
Cc: Jeff Law <law at redhat dot com>, Bernd Edlinger <bernd dot edlinger at hotmail dot de>, Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, Trevor Saunders <tbsaunde+gcc at tbsaunde dot org>
Date: Wed, 21 Sep 2016 01:13:41 +0200
Subject: Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
Authentication-results: sourceware.org; auth=none
References: <HE1PR0701MB2169A9451BDA56D552F8A55BE4F00@HE1PR0701MB2169.eurprd07.prod.outlook.com> <8ef95068-7826-ab09-6c22-12dd381aa808@redhat.com> <AM4PR0701MB2162988B6191CE63D2B0A1FFE4F40@AM4PR0701MB2162.eurprd07.prod.outlook.com> <57E11D80.9080409@foss.arm.com> <HE1PR0701MB216991D5B80F188EDCA94684E4F70@HE1PR0701MB2169.eurprd07.prod.outlook.com> <57E14591.9000903@foss.arm.com> <HE1PR0701MB2169132889D7C4529055D1E9E4F70@HE1PR0701MB2169.eurprd07.prod.outlook.com> <53afedf9-3678-50ba-0b59-d9b6c82a8917@redhat.com> <1f90009a-ed08-c657-9d25-198c27827c1f@redhat.com> <20160920230906.3mcel4wemkkbgdw6@ball>

On 09/21/2016 01:09 AM, Trevor Saunders wrote:


I thought I remember discussing this macro with you, but see what was
checked in I'll believe I'm thinking of something similar but different.

I think this here was an earlier patch and the one we were discussingrecently was the other macro with a similar name.

Any way sorry about the dumb bug

Stuff like this happens, no worries. But I've seen it happen a lot overthe years, and maybe you can see in this an explanation of why I'm oftennot the most enthusiastic supporter of pure cleanup patches (those notmotivated by more substantial patches depending on them).



Bernd

Follow-Ups:
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Trevor Saunders

References:
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Jeff Law
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Bernd Edlinger
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Kyrill Tkachov
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Bernd Edlinger
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Kyrill Tkachov
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Bernd Edlinger
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Jeff Law
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Bernd Schmidt
- Re: [PATCHv3, resent] Add a warning for suspicious use of conditional expressions in boolean context
  - From: Trevor Saunders

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]