This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fw at deneb dot enyo dot de: [PATCH] ada/77535: GNAT.Perfect_Hash_Generators for non-1-based strings]
- From: Thomas Quinot <quinot at adacore dot com>
- To: fw at deneb dot enyo dot de, gcc-patches at gcc dot gnu dot org
- Cc: charlet at adacore dot com, Eric Botcazou <botcazou at adacore dot com>
- Date: Sun, 18 Sep 2016 23:58:28 +0200
- Subject: Re: [fw at deneb dot enyo dot de: [PATCH] ada/77535: GNAT.Perfect_Hash_Generators for non-1-based strings]
- Authentication-results: sourceware.org; auth=none
- References: <20160909073047.GA21549@adacore.com>
> This patch fixes GNAT.Perfect_Hash_Generators for strings which are
> not 1-based. It does this by introducing its own storage type which
> fixes the first index as 1. This is also a minor optimization because
> it avoids the need to store the index.
>
> Okay for trunk?
>
> Should I try to construct a new test case for this? I don't see any
> existing tests for this package.
Florian,
Sorry for the delay in reviewing your patch. It looks good on the
surface; we're QAing it internally to make sure it does not break
PolyORB (which is the primary consumer of g-pehage). I'll let you know
as soon as I have the results from that run.
In any case it would be good to include a regression test for this
issue.
Thanks!
Thomas.
--
Thomas Quinot, Ph.D. ** quinot@adacore.com ** IT Lead Engineer
AdaCore -- Paris, France -- New York, USA