This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] Tidy build_unary_op
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 12 Sep 2016 21:53:52 +0000
- Subject: Re: [C PATCH] Tidy build_unary_op
- Authentication-results: sourceware.org; auth=none
- References: <20160910163653.GL19950@redhat.com>
On Sat, 10 Sep 2016, Marek Polacek wrote:
> A minor cleanup. First, FLAG is a really bad name for a parameter, and second,
> using two vars for the same thing is redundant (we never modify any of them).
> Also some bad formatting.
>
> Bootstrap/regtest on x86_64-linux running. Ok for trunk?
OK. If changing this argument it would seem natural to make it a bool
(and update callers to use true/false), unless that would be confusing for
other reasons (e.g. passing it through to other functions where the
corresponding argument isn't boolean).
--
Joseph S. Myers
joseph@codesourcery.com