This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Allow FP to be used as a call-saved registe
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Tamar Christina <Tamar dot Christina at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, <vmakarov at redhat dot com>
- Date: Mon, 12 Sep 2016 10:21:31 +0100
- Subject: Re: [PATCH] Allow FP to be used as a call-saved registe
- Authentication-results: sourceware.org; auth=none
- Nodisclaimer: True
- References: <VI1PR0801MB2031CAD1F37FA14F8AA4B6CEFFE60@VI1PR0801MB2031.eurprd08.prod.outlook.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Mon, Sep 05, 2016 at 03:59:18PM +0100, Tamar Christina wrote:
> Hi All,
>
> This patch allows the FP register to be used as a call-saved
> register when -fomit-frame-pointer is used.
>
> The change is done in such a way that the defaults do not change.
> To use the FP register both -fomit-frame-pointer and
> -fcall-saved-<hard_fp_reg> need to be used.
>
> Regression ran on aarch64-none-linux-gnu and no regressions.
> Bootstrapped and ran regressions on `x86_64` and no regressions.
>
> A new test fp_free_1 was added to test functionality.
>
> Ok for trunk?
>
> Thanks,
> Tamar
>
> PS. I don't have commit rights so if OK can someone apply the patch for me.
>
> gcc/
> 2016-09-01 Tamar Christina <tamar.christina@arm.com>
>
> * gcc/reginfo.c (fix_register): Allow FP to be set if
> -fomit-frame-pointer.
>
> gcc/testsuite/
> 2016-08-17 Tamar Christina <tamar.christina@arm.com>
>
> * gcc.target/aarch64/fp_free_1.c: New.
The AArch64 testcase is fine. But this change is to generic code, so you'll
want to CC some maintaners for that area (check the MAINTAINERS file) rather
than Richard, Marcus and myself. I've added Vlad to CC for you.
Thanks,
James