This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/9] cfgcleanup: Don't confuse CFI when -fshrink-wrap-separate
- From: Jeff Law <law at redhat dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>, gcc-patches at gcc dot gnu dot org
- Cc: bschmidt at redhat dot com
- Date: Thu, 8 Sep 2016 11:48:43 -0600
- Subject: Re: [PATCH 2/9] cfgcleanup: Don't confuse CFI when -fshrink-wrap-separate
- Authentication-results: sourceware.org; auth=none
- References: <cover.1470015604.git.segher@kernel.crashing.org> <e03b8b3273b84107c8b8d39ff6dc5130921d9710.1470015604.git.segher@kernel.crashing.org>
On 07/31/2016 07:42 PM, Segher Boessenkool wrote:
cfgcleanup would try to join noreturn paths with different components
handled. This then fails in dwarf2cfi.
2016-06-07 Segher Boessenkool <segher@kernel.crashing.org>
* cfgcleanup.c (outgoing_edges_match): Don't join noreturn calls
if shrink_wrapped_separate.
So if you only have fake edges, then you've got a non-returning call. If
you could twiddle the comment to make that clear it'd be appreciated.
Obviously you could look at the components and allow joining if the
components are the same. But I don't know if that happens enough in
practice to be worth the effort.
OK with the comment update if/when the kit as a whole is approved.
jeff