This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/4] Improvements to typed_splay_tree

From: Bernd Schmidt <bschmidt at redhat dot com>
To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Wed, 31 Aug 2016 16:12:21 +0200
Subject: Re: [PATCH 2/4] Improvements to typed_splay_tree
Authentication-results: sourceware.org; auth=none
References: <1472002128-4305-1-git-send-email-dmalcolm@redhat.com> <1472002128-4305-3-git-send-email-dmalcolm@redhat.com>

On 08/24/2016 03:28 AM, David Malcolm wrote:

+/* Helper type for typed_splay_tree::foreach.  */
+
+template <typename KEY_TYPE, typename VALUE_TYPE>
+struct closure

Is this in the global namespace? If so, something more specific than"closure" might be more appropriate. Or move the struct into thetyped_splay_tree class definition.


Looks ok otherwise.


Bernd

References:
- [PATCH 0/4] Applying fix-its on behalf of the user to their code
  - From: David Malcolm
- [PATCH 2/4] Improvements to typed_splay_tree
  - From: David Malcolm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]