This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Ping : [Patch, fortran] PR48298 - [F03] User-Defined Derived-Type IO (DTIO)
- From: Damian Rouson <damian at sourceryinstitute dot org>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>, Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- Cc: Jane Sleightholme <jane at fortranplus dot co dot uk>, jerry DeLisle <jvdelisle at charter dot net>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, Ian Chivers <ian dot chivers at chiversandbryan dot co dot uk>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 28 Aug 2016 13:39:14 -0700
- Subject: Re: Ping : [Patch, fortran] PR48298 - [F03] User-Defined Derived-Type IO (DTIO)
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGiKvbLD8azLWWaxMSSpSXWb_qHWFFA3=MwG8VFK+-mZ+wg@mail.gmail.com> <CAO9iq9GgiWfta1xDMGo4YT4jShHGKRV0BcfnkTdr42qz4Vvhmg@mail.gmail.com> <CAO9iq9GgiWfta1xDMGo4YT4jShHGKRV0BcfnkTdr42qz4Vvhmg@mail.gmail.com>
On August 27, 2016 at 1:15:51 PM, Janne Blomqvist (blomqvist.janne@gmail.com(mailto:blomqvist.janne@gmail.com)) wrote:
>
> Anyway, a small nit I found was the function st_set_nml_var in
> libgfortran. This is an exported function, and thus part of the ABI.
> So you cannot add arguments to it, as that would break backwards
> compatibility. I suggest you make a new function (say,
> st_set_nml_var2, or whatever), and make the old one a simple wrapper
> that calls the new one with the additional arguments set to null.
>
As another small nit, I hope the chosen name is more descriptive than one
obtained by appending “2” to the name. :)
Damian