This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Ping : [Patch, fortran] PR48298 - [F03] User-Defined Derived-Type IO (DTIO)
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, jerry DeLisle <jvdelisle at charter dot net>, Damian Rouson <damian at sourceryinstitute dot org>, Ian Chivers <ian dot chivers at chiversandbryan dot co dot uk>, Jane Sleightholme <jane at fortranplus dot co dot uk>
- Date: Sat, 27 Aug 2016 23:15:19 +0300
- Subject: Re: Ping : [Patch, fortran] PR48298 - [F03] User-Defined Derived-Type IO (DTIO)
- Authentication-results: sourceware.org; auth=none
- References: <CAGkQGiKvbLD8azLWWaxMSSpSXWb_qHWFFA3=MwG8VFK+-mZ+wg@mail.gmail.com>
On Sat, Aug 27, 2016 at 9:50 PM, Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
> Although we have said that we would commit on Monday if no review is
> forthcoming, we would very much prefer that somebody takes a look. We
> understand perfectly that a 4052 line patch is rather daunting.
> However, even a cursory scan of the patch would be helpful.
To be honest, I had a nagging suspicion that DTIO would remain forever
on the TODO list, but as you and Jerry have pulled it off, my hat is
off to you!
Anyway, a small nit I found was the function st_set_nml_var in
libgfortran. This is an exported function, and thus part of the ABI.
So you cannot add arguments to it, as that would break backwards
compatibility. I suggest you make a new function (say,
st_set_nml_var2, or whatever), and make the old one a simple wrapper
that calls the new one with the additional arguments set to null.
(Unfortunately I haven't looked thoroughly at the entire patch, so I
cannot say this is a complete review. Sorry!)
(Trying to send again as my previous message was caught by the mailing
list spam filters. Lets see if this one is more successful).
--
Janne Blomqvist