This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch

From: Martin Sebor <msebor at gmail dot com>
To: David Malcolm <dmalcolm at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 25 Aug 2016 10:30:40 -0600
Subject: Re: [PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch
Authentication-results: sourceware.org; auth=none
References: <1472141352-10884-1-git-send-email-dmalcolm@redhat.com> <1472142198-12113-1-git-send-email-dmalcolm@redhat.com>

On 08/25/2016 10:23 AM, David Malcolm wrote:

Martin: here are the fixups for your patch I needed to apply to make
it work with mine.  I couldn't actually get any of your existing test
cases to emit locations within the string literals, due to them all
being embedded in macro expansions (possibly relating to PR c/77328),
so I added a simple testcase using -fdiagnostics-show-caret, which
does successfully show a range within the string.

Posting in the hope that it's helpful; I haven't attempted a bootstrap
with it.


Thanks!  Let me go through it, test it and get back to you when I'm
done (sometime next week after I get back from PTO).

Martin

Follow-Ups:
- Re: [PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch
  - From: Martin Sebor

References:
- [PATCH] Move class substring_loc from c-family into gcc
  - From: David Malcolm
- [PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch
  - From: David Malcolm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]