This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3 PATCH] Implement C++17 make_from_tuple.


On 11 August 2016 at 21:05, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
>> The latest SD-6 has a feature test macro;
>>
>> #define __cpp_lib_make_from_tuple  201606
>>
>>
>> Also the test should get:
>>
>> #ifndef __cpp_lib_make_from_tuple
>> # error "Feature-test macro for make_from_tuple missing"
>> #elif __cpp_lib_make_from_tuple != 201606
>> # error "Feature-test macro for make_from_tuple has wrong value"
>> #endif
>
>
> Thanks, I tried to find a recent SD-6 when looking for a feature macro
> for make_from_tuple, but couldn't find one.
> I was not looking in the right place. :)

Here. Tested on Linux-x64. I made the test for the macro value compare
it relatively rather than exactly;
I don't think our tests should necessarily break just because a macro
value is updated.

2016-08-14  Ville Voutilainen  <ville.voutilainen@gmail.com>

    Add a feature macro for C++17 make_from_tuple.
    * include/std/tuple (__cpp_lib_make_from_tuple): New.
    * testsuite/20_util/tuple/make_from_tuple/1.cc: Adjust.

Attachment: make_from_tuple_feature.macro.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]