This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, fixincludes] Fix PR bootstrap/72833
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: Bruce Korb <bkorb at gnu dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 9 Aug 2016 17:00:59 +0000
- Subject: Re: [PATCH, fixincludes] Fix PR bootstrap/72833
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=softfail (sender IP is 10.152.2.59) smtp.mailfrom=hotmail.de; gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=hotmail.de;
- References: <AM4PR0701MB21624904B3A14A86C8967895E41C0@AM4PR0701MB2162.eurprd07.prod.outlook.com> <CAKRnqNJk=56c9CtomFhohfqBQpwO8k-w2HER0tKztqVjL0TZHA@mail.gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 08/09/16 18:28, Bruce Korb wrote:
> Index: fixincludes/fixincl.tpl
>
> ===================================================================
>
> --- fixincludes/fixincl.tpl (revision 239193)
>
> +++ fixincludes/fixincl.tpl (working copy)
>
> @@ -1,7 +1,7 @@
>
> [= AutoGen5 Template -*- Mode: C -*-
>
> x=fixincl.x =]
>
> [=
>
> - (if (version-compare >= autogen-version "5.18")
>
> + (if (version-compare >= autogen-version "5.18.1")
>
> (dne "-D" " * " "/* ")
>
> (dne " * " "/* ") ) =]
>
> Was this causing a problem? If so, then it all looks good to me. I
> had thought the "-D" was implemented in 5.18, but that was long, long
> ago now.
>
Yes. I was surprised that genfixes generated a bogus fixincl.x
there was no warning, but the result did not compile in the end.
You can see the result as the first obsoleted patch in the PR 72833.
I use autogen 5.18 from Ubuntu 14.04.
Thanks
Bernd.
> On Tue, Aug 9, 2016 at 5:17 AM, Bernd Edlinger
> <bernd.edlinger@hotmail.de> wrote:
>> Hi!
>>
>> Due to my recent cleanup of special_function_p the darwin bootstrap is
>> currently broken because the longjmp function misses the noreturn
>> attribute. Therefore I revived an old solaris_longjmp_noreturn
>> fixinclude rule.
>>
>> See the attached patch.
>>
>> Boot-strap on i686-apple-darwin11 and x86_64-apple-darwin11 was
>> successful.
>>
>> Is it OK for trunk?
>>
>>
>> Thanks
>> Bernd.