This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Fortran, Patch, PR72698, v1] [5/6/7 Regression] ICE in lhd_incomplete_type_error, at langhooks.c:205
- From: Thomas Koenig <tkoenig at netcologne dot de>
- To: Andre Vehreschild <vehre at gmx dot de>, GCC-Patches-ML <gcc-patches at gcc dot gnu dot org>, GCC-Fortran-ML <fortran at gcc dot gnu dot org>
- Date: Mon, 8 Aug 2016 08:42:08 +0200
- Subject: Re: [Fortran, Patch, PR72698, v1] [5/6/7 Regression] ICE in lhd_incomplete_type_error, at langhooks.c:205
- Authentication-results: sourceware.org; auth=none
- References: <20160807135234.7dd4c7fc@vepi2>
Am 07.08.2016 um 13:52 schrieb Andre Vehreschild:
Hi Andre,
attached patch fixes the ICE caused by a zero-sized string. Assigning
that string to a temporary variable obviously did not work out. The
patch fixes this by checking for zero-sized strings in SOURCE= and not
producing the code to assign "nothing" to the temporary
variable and later to the allocated memory. The version for gcc-5 had
to be adapted slightly, because the version of the ALLOCATE()
implementation is way behind.
Bootstrapped and regtested on x86_64-linux-gnu/F23. Ok for trunk, gcc-6
and gcc-5?
Looks good.
With the test case, you might consider changing that into a runtime
test to make sure that the correct result is obtained.
So, OK with that change.
Regards
Thomas