This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
On Fri, Aug 05, 2016 at 08:27:39AM -0700, Andrew Pinski wrote:
> On Fri, Aug 5, 2016 at 12:32 AM, Martin Liška <mliska@suse.cz> wrote:
> > On 08/05/2016 09:30 AM, Martin Liška wrote:
> >> Hi.
> >>
> >> Sorry for the mistake with the enum, that was silly ;)
> >> New patch version also handles the unnecessary braces.
> >>
> >> Martin
> >
> > I attached a wrong patch, sending the new one.
>
>
> This broke cross aarch64-elf-gnu building.
>
> /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/gcc/gcov.c:
> In function ‘loop_type handle_cycle(const arc_vector_t&, int64_t&)’:
> /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/gcc/gcov.c:468:25:
> error: ‘INT64_MAX’ was not declared in this scope
>
>
> See http://stackoverflow.com/questions/3233054/error-int32-max-was-not-declared-in-this-scope
> .
Fixed thusly, committed as obvious to trunk:
2016-08-06 Jakub Jelinek <jakub@redhat.com>
* gcov.c (handle_cycle): Use INTTYPE_MAXIMUM (int64_t) instead of
INT64_MAX.
--- gcc/gcov.c.jj 2016-08-06 12:11:51.000000000 +0200
+++ gcc/gcov.c 2016-08-06 12:28:32.373898684 +0200
@@ -465,7 +465,7 @@ handle_cycle (const arc_vector_t &edges,
{
/* Find the minimum edge of the cycle, and reduce all nodes in the cycle by
that amount. */
- int64_t cycle_count = INT64_MAX;
+ int64_t cycle_count = INTTYPE_MAXIMUM (int64_t);
for (unsigned i = 0; i < edges.size (); i++)
{
int64_t ecount = edges[i]->cs_count;
Jakub
- References:
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)
- Re: [PATCH] gcov tool: Implement Hawick's algorithm for cycle detection, (PR gcov-profile/67992)