Re: [PATCH] Fix unsafe function attributes for special functions (PR 71876)

[Jeff Law <law at redhat dot com>]

On 07/26/2016 09:48 AM, Bernd Edlinger wrote:

> Richard, this was the latest version of the patch:
> https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01481.html
>
>
> Are you OK with my clean-up of the presumably dead function names,
> or would you like to keep the quirks in special_function_p for now
> and just remove ECF_NORETURN and ECF_LEAF?
The only worry I have left is we're not catching _ prefixed savectx, 
vfork & getcontext (the the latter two being the important ones). 
Various ports still use USER_LABEL_PREFIX, so those symbols might be 
showing up as _vfork & friends.

That might just be an oversight (using name instead of tname in the 
simplified conditional).

> Note, that I still consider it incorrect, that special_function_p
> cannot distinguish between C and C++ bindings though.
I'd tend to agree.  We weren't even thinking about C++ when this code 
was original written and later extended.

jeff