Re: [AArch64][0/14] ARMv8.2-A FP16 extension support

[James Greenhalgh <james dot greenhalgh at arm dot com>]

On Thu, Jul 07, 2016 at 05:12:48PM +0100, Jiong Wang wrote:
> Hello,
> 
> As a follow up of
> 
> https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01240.html,
> 
> This patch set adds ARMv8.2-A FP16 scalar and vector intrinsics support,
> gcc middle-end will also be aware of some standard operations that some
> instructions can be auto-generated.
> 
> According to ACLE, ARMv8.2-A FP16 intrinsics for AArch64 is superset of
> intrinsics for AArch32, so all those intrinsic related testcases,
> particularly those under the directory advsimd-intrinsics, are also
> appliable to AArch64.  This patch set has only included those testcases
> that are exclusive for AArch64.
> 
> Jiong Wang (14)
>   ARMv8.2-A FP16 data processing intrinsics
>   ARMv8.2-A FP16 one operand vector intrinsics
>   ARMv8.2-A FP16 two operands vector intrinsics
>   ARMv8.2-A FP16 three operands vector intrinsics
>   ARMv8.2-A FP16 lane vector intrinsics
>   ARMv8.2-A FP16 reduction vector intrinsics
>   ARMv8.2-A FP16 one operand scalar intrinsics
>   ARMv8.2-A FP16 two operands scalar intrinsics
>   ARMv8.2-A FP16 three operands scalar intrinsics
>   ARMv8.2-A FP16 lane scalar intrinsics

At this point, I've OKed the first 10 patches in the series, these represent
the functional changes to the compiler. I'm leaving the testsuite patches
for now, as they depend on testsuite changes that have yet to be approved
for the ARM port.

To save you from having to continue to rebase the functional parts of this
patch while you wait for review of the ARM changes, I would be OK with you
committing them now, on the understanding that you'll continue to check
the testsuite in the time between now and the testsuite changes are approved,
and that you'll fix any issues that you find.

>   ARMv8.2-A FP16 testsuite selector
>   ARMv8.2-A testsuite for new data movement intrinsics
>   ARMv8.2-A testsuite for new vector intrinsics
>   ARMv8.2-A testsuite for new scalar intrinsics
 
I've taken a brief look through these testsuite changes and they look OK
to me. I'll revisit them properly once I've seen the ARM patches go in.

Thanks,
James