This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch GCC/01]Bring back warning message on loop whose counter might overflow

From: "Bin.Cheng" <amker dot cheng at gmail dot com>
To: Richard Biener <richard dot guenther at gmail dot com>
Cc: Bin Cheng <Bin dot Cheng at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>
Date: Fri, 22 Jul 2016 13:15:11 +0100
Subject: Re: [Patch GCC/01]Bring back warning message on loop whose counter might overflow
Authentication-results: sourceware.org; auth=none
References: <HE1PR0801MB1755DEADDCB36E7D9AFCDEAEE7090@HE1PR0801MB1755.eurprd08.prod.outlook.com> <CAFiYyc1eqJbaiXms5e=NqYyvHpzLxrDDQsUtFmdNXe9BOUHuxQ@mail.gmail.com>

On Fri, Jul 22, 2016 at 12:39 PM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Thu, Jul 21, 2016 at 6:48 PM, Bin Cheng <Bin.Cheng@arm.com> wrote:
>> Hi,
>> Previous patch removed warning message on loops whose counter might overflow, while this patch adds it back.  Reason is it's always good to have a warning message indicating missed loop optimizations.  Also warning message itself is slightly changed.
>> There will be following patch which removes -funsafe-loop-optimizations.
>>
>> Bootstrap and test on x86_64.  Is it OK?
>
> Please do not use 'input_location'.  You never should check
> LOCATION_LINE either but
> just for loc != UNKNOWN_LOCATION.  Note that simply passing
> gimple_location should
> work and fall back to sth sensible for UNKNOWN_LOCATION.
>
> Ok with that change,
Thanks for reviewing, attachment is the updated patch.

Thanks,
bin
> Richard.
>

Attachment: warn-loop-optimizations-20160721.txt
Description: Text document

References:
- [Patch GCC/01]Bring back warning message on loop whose counter might overflow
  - From: Bin Cheng
- Re: [Patch GCC/01]Bring back warning message on loop whose counter might overflow
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]